Skip to content

brocken compiling with less v4 #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WuglyakBolgoink opened this issue Sep 5, 2021 · 6 comments · Fixed by #679
Closed

brocken compiling with less v4 #678

WuglyakBolgoink opened this issue Sep 5, 2021 · 6 comments · Fixed by #679

Comments

@WuglyakBolgoink
Copy link
Contributor

to support LESS v4 you must wrap math operations with (...)

example

    margin-top: (-@handleSize / 2);
    padding-top: @handleSize / 2;

give back

    margin-top: -16px;
    padding-top: 32px/2;

and in this case padding-top will be ignored in browser and margin-top is correct!

please fix this asap!
@ValentinH
Copy link
Member

Thanks for reporting this. Would you like to create a PR?

WuglyakBolgoink added a commit to WuglyakBolgoink/angularjs-slider that referenced this issue Sep 6, 2021
@WuglyakBolgoink
fix: add parentheses around division-like expr's
b73700d 
More info https://github.com/less/less.js/releases/tag/v4.0.0

Closes angular-slider#678
@WuglyakBolgoink WuglyakBolgoink mentioned this issue Sep 6, 2021
Merged
@WuglyakBolgoink
Copy link
Contributor Author

@ValentinH are you published to npm now?

@ValentinH
Copy link
Member

It should be the case already or maybe I published to the wrong registry 🙈

@WuglyakBolgoink
Copy link
Contributor Author

@ValentinH

It should be the case already or maybe I published to the wrong registry 🙈

till now, nothing )

@ValentinH
Copy link
Member

It should be good now: v7.0.1

@WuglyakBolgoink
Copy link
Contributor Author

@ValentinH yes! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add parentheses around division-like expr's WuglyakBolgoink/angularjs-slider
2 participants
@WuglyakBolgoink @ValentinH