-
-
Notifications
You must be signed in to change notification settings - Fork 497
Allow changing step attribute #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I understand what you mean. However, as I said in #78, this change will probably break existing apps (like if someone is using Moreover, when changing the step with your solution, a NaN appears briefly above the slider so I think you are missing something... I think if we do this, we should do the same for the |
If you don't want to break existing implementations why don't you introduce a new 'rz-slider-nonStaticStep' or something? I need this feature so you have my vote :) 👍 |
Hmmm I'm not really fan of this solution because I already think that there are too many attributes on this directive.... I'm even considering using a What do you think of this solution? This would definitively be a 2.0 release. |
Sounds good 👍 |
Stupid question... Why does this dynamic step change works? |
There is no watch on step alone but since you modify other properties that are watched (model for instance), the slider is refreshed and so the step is updated. |
OK and here https://jsfiddle.net/zfee1pxb/5/ the update is triggered when moving the bubble right? So the only thing that does not work yet is that the bubble does not jump around when changing the step right? |
Not only because if you show the ticks on the slider, then they are not updated either: |
I have started to implement what I mentioned above about rzSliderOptions: |
It looks like mentioned :) |
Please see #158 |
The rz-slider-step attribute is static and does not change, as do the min and max. See #78, which was closed without a working solution.