fixed reset of maxH element #204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you generate the dist files by runnning Demo of the issue: https://jsfiddle.net/7tfbnj92/ (last example) The problem is when JQuery is used.... |
|
updated |
|
Just to make it perfect: could you rebase on master so there is no conflict, squash everything so there is only one commit, and remove the temp folder / modified git .ignore . |
|
I can't merge it as is because there are conflicts. You need to rebase your branch on master and do the other steps I mentioned above. |
|
Merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
this.maxH.css('display', null);does not reset the style. Passing''does. This fixes an issue where the max slider bubble does not reappear when updating the model.