Selection bar not updating after rzSliderForceRender (fixed) #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will it also work when rz-slider-always-show-bar is set ? Calling thrHigh() calls updateSelectionBar() which updates selection bar. |
|
I am using it with rz-slider-always-show-bar="true", and it works as expected. Since thrLow() calls updateSelectionBar() that's enough. |
rzajac
added a commit
that referenced
this pull request
May 24, 2015
Selection bar not updating after rzSliderForceRender (fixed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some debugging I found the problem. rzSliderForceRender was calling thrHigh() even when not using range slider.
I guess this is a better fix than the previous one (#48)