Skip to content

rtl vertical #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
albahrawy opened this issue Nov 8, 2019 · 1 comment · Fixed by #335
Closed

rtl vertical #203

albahrawy opened this issue Nov 8, 2019 · 1 comment · Fixed by #335
Labels
bug help wanted
Milestone
v6

Comments

@albahrawy
Copy link

hi,
when we set direction to 'rtl' and it is vertial, it is not right to change offset ,
hin dragEvent function:
if(this.dir === 'rtl') {
offset = -offset;
}

it should be :
if (this.dir === 'rtl' && this.direction === 'horizontal') {
offset = -offset;
}
@albahrawy albahrawy added the bug label Nov 8, 2019
@beeman
Copy link
Collaborator

beeman commented Jul 23, 2020

Hi @albahrawy.

This seems like a nice addition, I'm happy to review and merge a PR that adds support for this.

@beeman beeman added this to the v6 milestone Jul 23, 2020
@Harpush Harpush mentioned this issue Dec 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
v6
Development

Successfully merging a pull request may close this issue.

fix: handle rtl in vertical direction correctly Harpush/angular-split
2 participants
@beeman @albahrawy