Skip to content

global config settings #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 26, 2021

Conversation

pawelwojkiewicz
Copy link
Contributor

This PR resolve the issue from: #166

@beeman
Copy link
Collaborator

beeman commented Nov 20, 2021

@pawelwojkiewicz it looks like this change breaks the other demo pages if the global config is not provided, could you look into this.

image

@pawelwojkiewicz
Copy link
Contributor Author

pawelwojkiewicz commented Nov 25, 2021 via email

@beeman
Copy link
Collaborator

beeman commented Nov 25, 2021

Hello beeman. You're right - there was missing @optional() additional to @Inject. I've added this. I also removed ts-ignore comment. Now everything should be fine.

Thanks! Can you rebase over the latest main branch? It updated to Angular 13 in the meanwhile

pawelwojkiewicz added 2 commits November 26, 2021 09:36
# Conflicts:
#	projects/angular-split/src/public_api.ts
@pawelwojkiewicz
Copy link
Contributor Author

pawelwojkiewicz commented Nov 26, 2021 via email

@beeman beeman merged commit 65a11d7 into angular-split:main Nov 26, 2021
@Jefiozie
Copy link
Member

@all-contributors please add @pawelwojkiewicz for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@Jefiozie

I've put up a pull request to add @pawelwojkiewicz! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@stephanebouget
Copy link

Hello, is there a documentation to see how to use it ?
ty!

@Harpush
Copy link
Collaborator

Harpush commented Oct 18, 2024

Hello, is there a documentation to see how to use it ? ty!

Before the 18 beta or on beta?

@stephanebouget
Copy link

Hello, is there a documentation to see how to use it ? ty!

Before the 18 beta or on beta?

On the 18 beta

@Harpush
Copy link
Collaborator

Harpush commented Oct 18, 2024

Hello, is there a documentation to see how to use it ? ty!

Before the 18 beta or on beta?

On the 18 beta

There is no updated documentation for the beta yet unfortunately.
To use global config on the beta you should import provideAngularSplitOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants