-
Notifications
You must be signed in to change notification settings - Fork 215
global config settings #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global config settings #309
Conversation
@pawelwojkiewicz it looks like this change breaks the other demo pages if the global config is not provided, could you look into this. |
# Conflicts: # projects/angular-split/src/public_api.ts
Done.
czw., 25 lis 2021 o 21:52 beeman ***@***.***> napisał(a):
… Hello beeman. You're right - there was missing @optional
<https://github.com/optional>() additional to @Inject
<https://github.com/Inject>. I've added this. I also removed ts-ignore
comment. Now everything should be fine.
Thanks! Can you rebase over the latest main branch? It updated to Angular
13 in the meanwhile
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#309 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGIWULPFM7JZNYZ7OEKN6N3UN2OZFANCNFSM5GF5UECA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@all-contributors please add @pawelwojkiewicz for code.
|
I've put up a pull request to add @pawelwojkiewicz! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
Hello, is there a documentation to see how to use it ? |
Before the 18 beta or on beta? |
On the 18 beta |
There is no updated documentation for the beta yet unfortunately. |
This PR resolve the issue from: #166