-
Notifications
You must be signed in to change notification settings - Fork 215
feat: add tabindex input and binding #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@SanderElias what about documentation of the new input? |
@SanderElias And one more thing - by calling the input tabindex won't it apply tabindex to the whole split? Shouldn't it be |
@Jefiozie @Harpush is right! We should unmerge this one ;) |
the question, and I don't know the answer, but I'm leaning toward no. |
I agree on leaning NO, I made a PR for the revert #440 |
False would keep it in line with current behaviour (i.e. keeping it in the flow). I think I agree with being it false to begin with. |
@Jefiozie the gutter should have 0 by default I think and will be -1 if provided true. So the default for the input is indeed false. Maybe add a global config for it? Might be overkill though. |
Yes, but in our first breaking release, we should toggle this. |
I am not entirely sure about it... Without it for example the keyboard gutter movement feature won't work |
Why was this reverted? How can I set it to -1? |
I reopened the issue |
@all-contributors please add @ConnorSmith-pf for code.
|
I've put up a pull request to add @ConnorSmith-pf! 🎉 |
Adds tabindex Input for split component & defaults to previous fixed value of 0.
Closes #432