Skip to content

ci: use npm instead of yarn #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

viceice
Copy link
Contributor

@viceice viceice commented Nov 20, 2024

@viceice
Copy link
Contributor Author

viceice commented Nov 20, 2024

it seems we need to relax peer dependencies 😔

Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@Jefiozie If everything checks out, this is one less "3rth party".
Assuming there is no issue with the peerdeps?

@SanderElias
Copy link
Contributor

@viceice @Jefiozie
The problem is that the package lock isn't generated correctly. Because of that, npm ci errors out. Not sure how/when that happened.

@viceice
Copy link
Contributor Author

viceice commented Nov 22, 2024

@SanderElias @Jefiozie I fixed the peer dependency issue via upgrading ngx-bootstrap1

Footnotes

  1. https://github.com/valor-software/ngx-bootstrap?tab=readme-ov-file#compatibility

@viceice
Copy link
Contributor Author

viceice commented Nov 22, 2024

ngx-bootstrap is only used for tests, not a dep of the published package

@Jefiozie Jefiozie merged commit 4f5b26c into angular-split:main Nov 23, 2024
5 checks passed
@viceice viceice deleted the ci/use-npm branch November 23, 2024 09:09
@Jefiozie
Copy link
Member

Jefiozie commented Feb 2, 2025

@all-contributors please add @viceice for infra.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@Jefiozie

I've put up a pull request to add @viceice! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants