Skip to content

fix: use afterRender and host #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 30, 2025
Merged

fix: use afterRender and host #514

merged 6 commits into from
May 30, 2025

Conversation

SanderElias
Copy link
Contributor

@SanderElias SanderElias commented May 29, 2025 •
edited
Loading

@Harpush @Jefiozie
I moved the effect to afterrendereffect, and moved the other effect into 'host'

With this change, we no longer need to use renderer2 in the component. Also, AFAIK, there is no change in the CD of the parent component. Using the computed value ensures that the thing is debounced as accurately as possible.

I'm not 100% sure about this thing tho, so please review carefully

should closes #513

@SanderElias SanderElias requested review from Harpush and Jefiozie May 29, 2025 11:00
@Harpush
Copy link
Collaborator

Harpush commented May 29, 2025

  1. The afterRenderEffect should fix the issue - but I wonder if a specific phase is needed?
  2. The effect to host I will need to check once I am not on phone later today

@SanderElias
Copy link
Contributor Author

@Harpush
I looked into the phase. I can move it to the read phase, as there are no dom updates as a result of this. (Logging to the console isn't writing) and it will run at the last possible time (so all signals should be updated by then)

I'll push an commit where I do that.

@SanderElias
Copy link
Contributor Author

BTW, I have no idea why the linter now forced me to remove the ; in split-transitions.component.ts

However, it was a stray, unneeded ;, so that comes as a drive-by fix.

Harpush
Harpush reviewed May 29, 2025
View reviewed changes
@SanderElias SanderElias requested a review from Harpush May 30, 2025 06:51
Harpush
Harpush reviewed May 30, 2025
View reviewed changes
@SanderElias SanderElias requested a review from Harpush May 30, 2025 08:06
Harpush
Harpush approved these changes May 30, 2025
View reviewed changes
Copy link
Collaborator

@Harpush Harpush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanderElias SanderElias merged commit 3511e50 into main May 30, 2025
7 checks passed
@SanderElias SanderElias deleted the Propose_host branch May 30, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harpush Harpush Harpush approved these changes

@Jefiozie Jefiozie Awaiting requested review from Jefiozie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning when deleting a split area.
2 participants
@SanderElias @Harpush