-
Notifications
You must be signed in to change notification settings - Fork 4
Corrected link to jhipster logo #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
</ul> | ||
</div> | ||
</div> | ||
</div> | ||
<footer class="footer"> | ||
<div class="container"> | ||
<p>Brought to you by <br><a href="http://github.com/PascalPrecht"> <img width="40" height="40" src="https://secure.gravatar.com/avatar/b32bdb1fc9fdadeb45d7a1267fdd2fc4?s=40"> Pascal Precht</a> <a href="http://github.com/knalli"><img height="210" src="https://secure.gravatar.com/avatar/6c349ffd9793132e1d217f0de572e080?s=40" width="40" height="40"> Jan Philipp</a> <a href="http://github.com/DWand"><img height="40" width="40" src="https://secure.gravatar.com/avatar/2146036b95ee605ca39779b958cd54ce?s=40"> Max Prichinenko</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is that change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea. Just opened ìndex.html
in atom editor, changed the url of the logo and there was this additional diff.
Edit: Looks like an additional space at the end of the line in my local git history.
Thank you. Besides the questions I've already posted: You should make PRs from and against branch |
I can't squash my commits nicely as they are already pushed (or am i wrong?). Maybe just reject this PR and I'll create a new PR from a dedicated branch? |
You have to push with |
Squashed and pushed with a lot of force :) |
My comment about branch Last line is a removed space... |
Corrected link to jhipster logo
Thank you! |
JHipster has a new logo.