Skip to content
This repository was archived by the owner on Nov 30, 2018. It is now read-only.

GoogleMapApi and IsReady descriptions are explicit about usage re control object augmentation #1361

Merged
merged 2 commits into from
Jun 14, 2015
Merged

GoogleMapApi and IsReady descriptions are explicit about usage re control object augmentation #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c55eba6
Add note about control objects to IsReady.html
rummelsworth Jun 13, 2015
55bdf5b
Added note about control objects to GoogleMapApi.html
rummelsworth Jun 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/views/provider/GoogleMapApi.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@
It guarantees that angular-google-maps does not begin processing any directives until all of the Google Maps SDK is fully ready!
</li>
</ul>

<div class="alert alert-info">
<code>uiGmapGoogleMapApi</code> (<em>this service</em>) should not be used to wait for directives to finish
augmenting <code>control</code> objects. The <code>uiGmapIsReady</code> service should be used instead.
</div>

To utilize this provider you must load it and configure it properly. Please note the
<a href="https://github.com/angular-ui/angular-google-maps/blob/develop/src/coffee/providers/map-loader.coffee#L31-L50">defaults</a>!

Expand Down
5 changes: 5 additions & 0 deletions app/views/service/IsReady.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
</li>
</ul>

<div class="alert alert-info">
The <code>uiGmapGoogleMapApi</code> service should not be used to wait for directives to finish
augmenting <code>control</code> objects. <code>uiGmapIsReady</code> (<em>this service</em>) should be used instead.
</div>

<a href="https://github.com/angular-ui/angular-google-maps/blob/develop/src/coffee/directives/api/utils/is-ready.coffee">source code</a>

<div hljs language="js">
Expand Down