Fix issues loading Gmaps API in a cordova app when the app has no initial network connection #1567
Conversation
jabas06
commented
Oct 16, 2015
- The safety check for window.navigator.connection and window.Connection in cordova apps should wait until device is ready. See issue online listener is not added on Cordova app #1520
- There is an issue in cordova apps on android where network events (online/offline) are fired multiple times in a row. This PR includes a workaround to deal with this.
- Fixes an error raised when a script tag for Gmaps API is already in the document (see issue #<HTMLScriptElement> has no method 'remove' #1521). In my case this problem arose because the previous issue (network events fired multiple times ).
|
I need to find an evening to dig into this. Your other PR will probably get merged soon. |
| @@ -34,6 +38,25 @@ angular.module('uiGmapgoogle-maps.providers') | |||
| isGoogleMapsLoaded = -> | |||
| angular.isDefined(window.google) and angular.isDefined(window.google.maps) | |||
|
|
|||
| onWindowLoad = (options)-> | |||
| # if its a WebView | |||
| if !(!window.cordova && !window.PhoneGap && !window.phonegap && !window.forge) | |||
There was a problem hiding this comment.
So overall this looks good. But the main problem I have with it is all this extra logic to keep supporting different environments all thrown into one factory.
It would be nice if the onWindowLoad code actually comes from another provider, factory, or service where it can be overridden easily. I fear this will just keep growing.
@jabas06 I'll take care of this part. If u can confirm or add in the above functions for clarity that would be helpful.
|
@jabas06 ping? |
|
sorry @nmccready, I've been to busy. I'will try to push some changes with your suggestions this weekend. |
|
@jabas06 no worries just trying to double check if we can proceed with this. Thanks. |
remove unnecessary checks for network api.