Skip to content
This repository was archived by the owner on Nov 30, 2018. It is now read-only.

modified searchbox example #1573

Merged
merged 3 commits into from
Dec 20, 2015
Merged

modified searchbox example #1573

merged 3 commits into from
Dec 20, 2015

Conversation

kandizzy
Copy link
Contributor

Let's see if this gets the places library to load within the plunkr in the API docs. The code works in Plunkr by itself.

@nmccready
Copy link
Contributor

@kandizzy since your having problems with the loader possibly, can you add the google maps script day in the html and see if that fixes your issue? If so then there is a bug in the provider.

@nmccready
Copy link
Contributor

Any updates on this, status wise?

@kandizzy
Copy link
Contributor Author

Yeah, i'm working on it, but I still can't get the Plunkr's to load in localhost. Even if I hardcode the paths to the vendor scripts...

@kandizzy
Copy link
Contributor Author

@nmccready just an update here, I made the examples run in localhost to test. i was able to make the example work by including the places lib directly in the HTML. Next step is to figure out why the provider is not loading the places lib.

@nmccready
Copy link
Contributor

Ahh.. well this would be why Weather is not working as well.

@nmccready
Copy link
Contributor

Heads up you guys are messing in the same domain.. #1567

@kandizzy
Copy link
Contributor Author

kandizzy commented Nov 3, 2015

cool. thanks, I'll return to this on the weekend so I'll check in with that PR.

@kandizzy
Copy link
Contributor Author

@nmccready hey I haven't had a chance to get back at this, but I will this weekend. I will see if i can try to tackle some of the smaller issues where you've asked for a PR as well!

@nmccready
Copy link
Contributor

Cool TY

@nmccready
Copy link
Contributor

LGTM

nmccready added a commit that referenced this pull request Dec 20, 2015
modified searchbox example
@nmccready nmccready merged commit bdaaf1c into angular-ui:website Dec 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants