This repository was archived by the owner on Nov 30, 2018. It is now read-only.
More control over options passed to Map constructor. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for your work. It's indeed a nice way to pass options easily without adding too much attributes. We could use this technique to expose more options, like map type. |
nlaplante
added a commit
that referenced
this pull request
Mar 27, 2013
Merged. Will have to do additional work to make sure that options do not overwrite the center and zoom which comes from the parent scope. Some refactoring will be needed.
|
This is great work. But I'm wondering about being able to change certain options on the fly. For example, it could be great to be able to "lock" the map. One easy way to do that would be to set a value for minZoom and maxZoom—but I can't seem to see a good way of doing this after options are passed. Thoughts? |
|
On r1-dev I believe some of the options are bindable / watched. So if there are changes things should update immediately. |
|
Suggestion: maybe just add the format to the API documentation. With an example or something like that. P.S. Great work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Thanks for creating this library.
I wanted to be able to disable a few of the map controls. This meant that I needed to have more control over the options passed to the Map constructor.
I'm happy to refactor to suit your vision of the project.
Cheers,
Tate