Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Conversation

asleepwalker
Copy link
Contributor

No description provided.

@aaronroberson
Copy link
Contributor

Please remove dist files from PR :D

@asleepwalker
Copy link
Contributor Author

Done.

@aaronroberson aaronroberson merged commit 010a373 into angular-ui:master Jun 1, 2016
@user378230
Copy link
Contributor

@asleepwalker can you update the wiki please?

@asleepwalker
Copy link
Contributor Author

@user378230 of course, but where I should write about it? This pull request was not about adding callbacks like existing onSelect and onRemove, but only broadcasting an event.

There are similar scope events here:
https://github.com/angular-ui/ui-select/blob/master/src/uiSelectController.js#L114
https://github.com/angular-ui/ui-select/blob/master/src/uiSelectController.js#L391
https://github.com/angular-ui/ui-select/blob/master/src/uiSelectController.js#L420
and they are not documented in the wiki.

@user378230
Copy link
Contributor

@asleepwalker A sorry I saw the Events heading a thought they were scope events.

Feel free to add a section Scope Events to the ui select wiki page (the one I linked previously).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants