This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(resetSearchInput) change search box doesn't clear after selecting #1725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when the closeOnSelect was set to false the resetSearchInput was not executed after selecting a item even when resetSearchInput was set to true. This fix will always execute the resetSearchInput when set to true even with the closeOnSelect set to false. Fixes angular-ui#1484
|
|
||
| }); | ||
|
|
||
|
|
There was a problem hiding this comment.
Can you remove this extraneous empty line?
|
Can you shorten the tests by using |
|
I think this is better? |
|
Much better, will review the code changes when I get a chance and merge, thanks! 😃 |
|
Let me know if I need to make a change. |
…ed set to true." This reverts commit cfb50fe.
|
Sorry @user378230 for all the commit stuff. New to git and didn't realize i was still pushing it here. |
|
@Jefiozie think something went wrong here, can you rebase? or redo this PR? Sorry I've been away so haven't had a chance to look at PRs recently. |
|
I will rewrite it probably the best 😄 |
|
I think also this will resolve #1384 ? 😃 |
|
@user378230 #1746 is the new PR for this issue. 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(resetSearchInput) change search box doesn't clear after selecting
Previously when the closeOnSelect was set to false the resetSearchInput was not executed after selecting a item even when resetSearchInput was set to true.
This fix will always execute the resetSearchInput when set to true even with the closeOnSelect set to false.
Fixes #1484