This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Watch the allowClear attribute for changes #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the CSS selector more specific.
Fix z-index issue introduced by the `append-to-body` support …
|
Can you create a for test for this? |
|
There doesn't appear to be any existing unit tests for the allow-clear attribute so I'm not sure where I should put one. Do you have any suggestions? Could you suggest another unit test that would be a good example to start from. |
|
Created unit tests. |
|
Where did the changes to common.css come from? They seem to be from another pull request? |
dimirc
added a commit
that referenced
this pull request
Mar 17, 2015
Watch the allowClear attribute for changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently allowClear is only evaluated during the linking phase. If you want to be able to control this dynamically it needs to be watched for changes.