This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Fix issues with append-to-body #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dth of the select element, so that it can be properly restored after it gets moved back to its original location.
…comprehend right now, the transclude function needs to be called before the `appendToBody` attribute is wire up. Otherwise the height measurement is incorrect when the the dropdown is opened (using the Bootstrap theme) because both the `ui-select-match` and the `ui-select-choices` elements are visible at the same time. I'd appreciate if anyone could explain this, but this change does the trick for me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for two issues with the append-to-body functionality (see #736).
Here's a screenshot showing the results of “misplacing” the invocation of
transcludeFn.