Fixed bugs #92

soul4code · 2015-03-27T13:45:32Z

random order of load/add steps when using templates for wzStep directive
Nested wizards. Loading childwizard steps directive before run directive link function.

- random ordering when using templates for step directive - Nested wizards. Loading childwizard steps directive before run directive link function.

jacobscarter · 2015-04-03T02:41:48Z

@magnitronus I will get this merged as soon as I can, thanks.

raftheunis87 · 2015-04-23T06:24:01Z

@jacobscarter Any news on the merge? I currently have the following issue:

<wizard on-finish="finishedWizard()" hide-indicators="true" current-step="currentPage"> <wz-step title="{{page.label}}" ng-repeat="page in pages | orderBy:sequenceSort" class="clearfix"> <div ng-repeat="question in page.questions"> <question my-question="question" my-assignment-id="assignmentId" page="page" ng-model="question" class="questionMargin"></question> </div> {{page.sequence}} <button class="btn btn-primary pull-left" ng-click="cancel()">Annuleer</button> <button class="btn btn-primary pull-right" type="submit" wz-next>Volgende</button> </wz-step> </wizard>

The ng-repeat gets an ordered data-set. I even added an extra orderBy to make sure everything is ordered, but the steps still are randomly shown.

nfantone · 2015-04-24T17:44:37Z

@raftheunis87 That should work. Your ng-repeat is iterating over an array declared on your controller (pages), while the wizard keeps its own array in its own isolated scope. Steps get added as soon as each wzStep directive is created, and since you are ordering the steps declaration they should show accordingly.

Try using single quotes in the orderBy filter.

ng-repeat="page in pages | orderBy:'sequenceSort'"

(see the docs: https://docs.angularjs.org/api/ng/filter/orderBy)

lauraschoebel · 2016-03-09T19:06:16Z

is there any development on this? I'm having a similar issue with my wizard consisting of 3 steps, where the 2nd step is an ng-repeat. Due to issues discussed above the wizard orders it Step 1, Step 3, and then the Step 2 ng-repeats. I saw that the fix above contains a solution with orderIndex but the current version doesn't seem to support his yet. Any help would be appreciated.

jacobscarter · 2016-09-06T22:15:27Z

Can you fix merge conflicts, I will get it merged after, sorry for the huge delay

jacobscarter · 2017-06-06T21:42:34Z

src/step.js

        },
        require: '^wizard',
        templateUrl: function(element, attributes) {
          return attributes.template || "step.html";
        },
        link: function($scope, $element, $attrs, wizard) {
            $scope.title = $scope.title || $scope.wzTitle;
-            wizard.addStep($scope);
+
+            //for nested wizards. Add step when tempate for wizard is ready.


template not tempate

jacobscarter · 2017-06-06T21:43:05Z

src/step.js

+            }
+            else {
+                $rootScope.$on('mgo-angular-wizard.transcluded', function($event, wzName){
+                    if (wizard.name==wzName)  wizard.addStep($scope);


please use {} in your if statement. Please add space on either side of ==

jacobscarter · 2017-06-06T21:44:10Z

src/wizard.js

@@ -15,30 +15,74 @@ angular.module('mgo-angular-wizard').directive('wizard', function() {
            return attributes.template || "wizard.html";
        },

+        link: function($scope, $element, $attributes){
+
+            var get_stepnodes = function (parent)


{ on same like as argument declaration please

jacobscarter · 2017-06-06T21:44:48Z

src/wizard.js

+                {
+                  var matchingElements = [];
+                  var allElements = parent[0].getElementsByTagName('*');
+                  for (var i = 0, n = allElements.length; i < n; i++)


for (var i = 0; i < allElements.length; i++)

jacobscarter · 2017-06-06T21:45:11Z

src/wizard.js

+                  for (var i = 0, n = allElements.length; i < n; i++)
+                  {
+                    var current = allElements[i],
+                        $current = angular.element(current);


declare variable, correct whitespace.

jacobscarter · 2017-06-06T21:47:03Z

src/wizard.js

+                        $current = angular.element(current);
+
+                    if (!_.isUndefined($current.attr('wz-step')) || current.nodeName.toLowerCase()=='wz-step' || $current.hasClass('step'))
+                    {


{ on same line as ()

jacobscarter · 2017-06-06T21:47:25Z

src/wizard.js

+            var thisModule = this;
+
+            $scope.$watch('transcluded', function(val){
+                if (val) thisModule.transcluded = true;


jacobscarter · 2017-06-06T21:47:57Z

src/wizard.js

@@ -143,7 +200,7 @@ angular.module('mgo-angular-wizard').directive('wizard', function() {
            function unselectAll() {
                //traverse steps array and set each "selected" property to false
                _.each($scope.steps, function (step) {
-                    step.selected = false;
+                    if (step) step.selected = false;


{} on new line

jacobscarter · 2017-06-06T21:49:30Z

@magnitronus can you please fix your syntax to match the coding style of the other contributors for consistency, can you please rebase your branch off our master so you will have the updates that fix issues with automated CI checks failing, can you please write unit tests to cover your new functionality, can you please remove the dist files from your PR, as a reminder we have our contribution guidelines here: https://github.com/angular-wizard/angular-wizard/blob/master/CHANGELOG.md

nfantone · 2017-06-09T14:38:57Z

@jacobscarter Sorry to intrude and jump in here, but... what if instead of you acting as a human linter, we actually configure and use one? From my humble POV, you cannot enforce a particular coding style to contributors when you yourself don't (or your project doesn't).

On a related note, if you want to avoid contributors/members pushing specific files to the repo, those should be clearly ignored in .gitignore. Otherwise, you'll most likely end up correcting this time and again. Besides, the fact that you are checking build results into the repository is odd/confusing, to say the least.

Also, the link to the contribution guidelines should be: https://github.com/angular-wizard/angular-wizard/blob/master/CONTRIBUTE.md. You pointed to the changelog there.

jacobscarter · 2017-06-09T15:10:20Z

@nfantone great points, would you like to make a PR updating the gitignore and adding jslint?

jacobscarter · 2017-06-09T15:14:14Z

On second thought, the gitignore would prevent updated build files from pushing when appropriate (unless you have an idea for that). However I like the linter idea and would love to see that incorporated. :)

Fixed bugs:

2eefd58

- random ordering when using templates for step directive - Nested wizards. Loading childwizard steps directive before run directive link function.

jacobscarter added the waiting for update label Sep 6, 2016

jacobscarter requested changes Jun 6, 2017

View reviewed changes

jacobscarter added the enhancement label Jun 6, 2017

Fixed bugs #92

Are you sure you want to change the base?

Fixed bugs #92

Uh oh!

Conversation

soul4code commented Mar 27, 2015

Uh oh!

jacobscarter commented Apr 3, 2015

Uh oh!

raftheunis87 commented Apr 23, 2015

Uh oh!

nfantone commented Apr 24, 2015

Uh oh!

lauraschoebel commented Mar 9, 2016

Uh oh!

jacobscarter commented Sep 6, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jacobscarter commented Jun 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nfantone commented Jun 9, 2017

Uh oh!

jacobscarter commented Jun 9, 2017

Uh oh!

jacobscarter commented Jun 9, 2017

Uh oh!

Uh oh!

jacobscarter commented Jun 6, 2017 •

edited

Loading