Improve fileglob lookup - Pattern matching on directory & file #83600
+168
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test The test The test The test |
* Replace os.path by Pathlib library & refactor * Add new feature : Pattern matching on directory & file * Add new integration test for cover new feature
d6a70ab to
be6e985
Compare
For Windows path, there is a difference between `str(p)` & `p.as_posix()`
|
Seems correct, I did a review during pycon.fr with submitter and @pilou- The behavior did seems curious, but that was the original one, so I would say LGTM. |
felixfontein
reviewed
Feb 5, 2025
| - Matches all files in a single directory, non-recursively, that match a pattern. | ||
| It calls Python's "glob" library. | ||
| - Matches all files in directory that match a pattern. | ||
| It calls Python's "`Path.glob <https://docs.python.org/3/library/pathlib.html#pathlib.Path.glob>`_" library. |
There was a problem hiding this comment.
Suggested change
| It calls Python's "`Path.glob <https://docs.python.org/3/library/pathlib.html#pathlib.Path.glob>`_" library. | |
| It calls Python's "L(Path.glob, https://docs.python.org/3/library/pathlib.html#pathlib.Path.glob)" library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Hi, I modify and improve
filegloblookup for adding pattern matching to folder and keeping the previous behaviors.I made this change because I think it's a shame that this lookup doesn't have these features and that it's laborious to get the same behavior by other means.
I replace
os.pathlibrary byPathlibbecause it's a better library for manipulate filesystem paths. This library was added in Python 3.4. I add new integration test and examples for cover this new features. I run sanity and integration test forfileglob, there are no errors.I welcome any feedback to improve this PR. Thanks.
ISSUE TYPE