Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iam_managed_policy - remove unused fail_on_delete parameter #1168

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 25, 2022

SUMMARY

remove unused fail_on_delete parameter

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iam_managed_policy

ADDITIONAL INFORMATION

ansible/ansible#63961

@tremble tremble requested review from alinabuzachis and markuman May 25, 2022 20:32
@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label May 25, 2022
@github-actions
Copy link

github-actions bot commented May 25, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module owner_pr PR created by owner/maintainer plugins plugin (any type) small_patch Hopefully easy to review labels May 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 28s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 20s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 38s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 36s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 45s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 13m 14s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 12s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 23s
✔️ ansible-test-splitter SUCCESS in 2m 29s
✔️ integration-community.aws-1 SUCCESS in 6m 49s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 5m 39s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 54s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 49s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 28s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 46s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 12m 13s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 37s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 13s
✔️ ansible-test-splitter SUCCESS in 2m 27s
✔️ integration-community.aws-1 SUCCESS in 7m 48s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7095617 into ansible-collections:main May 26, 2022
@tremble tremble deleted the deprecation/4.0.0/iam_managed_policy branch July 7, 2022 19:27
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…ble-collections#1168)

S3_bucket : Handle setting of permissions while acl is disabled

SUMMARY


As per boto3 aws documentation
When ObjectOwnership is BucketOwnerEnforced - Access control lists (ACLs) are disabled and no longer affect permissions.
Fixes ansible-collections#1137
ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Jill R <None>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
Reviewed-by: GomathiselviS <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…collections#1168)

iam_managed_policy - remove unused fail_on_delete parameter

SUMMARY
remove unused fail_on_delete parameter
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_managed_policy
ADDITIONAL INFORMATION
ansible/ansible#63961

Reviewed-by: Markus Bergholz <git@osuv.de>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@7095617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module owner_pr PR created by owner/maintainer plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants