Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default value of purge_tags to True #1343

Merged
merged 5 commits into from
Jul 11, 2022
Merged

Update default value of purge_tags to True #1343

merged 5 commits into from
Jul 11, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 11, 2022

SUMMARY

Complete the deprecation cycle and update purge_tags default value to True

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/acm_certificate.py
plugins/modules/cloudfront_distribution.py
plugins/modules/ec2_vpc_vpn.py
plugins/modules/kms_key.py
plugins/modules/rds_param_group.py
plugins/modules/route53_health_check.py
plugins/modules/route53_zone.py
plugins/modules/sqs_queue.py

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @jillr @loia @markuman @matt-telstra @minichate @nand0p @s-hertel @sbj-ss @scottanderson42 @tastychutney @wilvk @zimbatm
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jul 11, 2022
@github-actions
Copy link

github-actions bot commented Jul 11, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 57s
✔️ build-ansible-collection SUCCESS in 5m 11s
❌ ansible-test-sanity-docker-devel FAILURE in 9m 49s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 11m 04s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 10m 45s
❌ ansible-test-sanity-docker-stable-2.13 FAILURE in 10m 40s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 40s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 58s
✔️ ansible-test-splitter SUCCESS in 2m 25s
❌ integration-community.aws-1 FAILURE in 29m 59s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label Jul 11, 2022
@ansibullbot ansibullbot added integration tests/integration tests tests and removed owner_pr PR created by owner/maintainer labels Jul 11, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 03s
✔️ build-ansible-collection SUCCESS in 5m 59s
❌ ansible-test-sanity-docker-devel FAILURE in 11m 32s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 13m 18s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 10m 16s
❌ ansible-test-sanity-docker-stable-2.13 FAILURE in 8m 55s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 54s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 43s
✔️ ansible-test-splitter SUCCESS in 2m 38s
❌ integration-community.aws-1 FAILURE in 25m 57s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble force-pushed the deprecations/5.0.0/purge_tags branch from 2479ff9 to 1bbc679 Compare July 11, 2022 11:12
@tremble tremble force-pushed the deprecations/5.0.0/purge_tags branch from 1bbc679 to 1afd30b Compare July 11, 2022 11:37
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 55s
✔️ build-ansible-collection SUCCESS in 6m 04s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 54s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 22s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 32s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 31s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 21s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 54s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-community.aws-1 SUCCESS in 24m 16s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 11, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 37s
✔️ build-ansible-collection SUCCESS in 6m 07s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 40s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 13m 16s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 31s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 55s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 39s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 10m 37s
✔️ ansible-test-splitter SUCCESS in 3m 00s
✔️ integration-community.aws-1 SUCCESS in 23m 42s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b56f3c6 into ansible-collections:main Jul 11, 2022
@tremble tremble deleted the deprecations/5.0.0/purge_tags branch September 9, 2022 09:02
@renovate renovate bot mentioned this pull request Oct 6, 2022
Merged
1 task
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @goneri
Update default value of purge_tags to True (ansible-collections#1343)
6310b5d 
Update default value of purge_tags to True

SUMMARY
Complete the deprecation cycle and update purge_tags default value to True
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/modules/acm_certificate.py
plugins/modules/cloudfront_distribution.py
plugins/modules/ec2_vpc_vpn.py
plugins/modules/kms_key.py
plugins/modules/rds_param_group.py
plugins/modules/route53_health_check.py
plugins/modules/route53_zone.py
plugins/modules/sqs_queue.py
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b56f3c6
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @goneri
Update default value of purge_tags to True (ansible-collections#1343)
cf1f525 
Update default value of purge_tags to True

SUMMARY
Complete the deprecation cycle and update purge_tags default value to True
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/modules/acm_certificate.py
plugins/modules/cloudfront_distribution.py
plugins/modules/ec2_vpc_vpn.py
plugins/modules/kms_key.py
plugins/modules/rds_param_group.py
plugins/modules/route53_health_check.py
plugins/modules/route53_zone.py
plugins/modules/sqs_queue.py
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b56f3c6
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @goneri
Update default value of purge_tags to True (ansible-collections#1343)
5178803 
Update default value of purge_tags to True

SUMMARY
Complete the deprecation cycle and update purge_tags default value to True
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/modules/acm_certificate.py
plugins/modules/cloudfront_distribution.py
plugins/modules/ec2_vpc_vpn.py
plugins/modules/kms_key.py
plugins/modules/rds_param_group.py
plugins/modules/route53_health_check.py
plugins/modules/route53_zone.py
plugins/modules/sqs_queue.py
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b56f3c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@markuman markuman markuman approved these changes

@jatorcasso jatorcasso Awaiting requested review from jatorcasso

Assignees
No one assigned
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tremble @ansibullbot @markuman @alinabuzachis