Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable deprecaded message for ignore_volatile_options #3429

Merged
merged 5 commits into from
Sep 28, 2021
Merged

Enable deprecaded message for ignore_volatile_options #3429

merged 5 commits into from
Sep 28, 2021

Conversation

conloos
Copy link
Contributor

@conloos conloos commented Sep 24, 2021

SUMMARY

Enable deprecated message if ignore_volatile_options is set to true.

This patch should not be ported back to previous versions .

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lxd_container

@ansibullbot ansibullbot added cloud feature This issue/PR relates to a feature request module module plugins plugin (any type) labels Sep 24, 2021
@felixfontein
Copy link
Collaborator

Can you please add a changlog fragment with a section deprecated_features? Thanks.

@felixfontein felixfontein added breaking_change This PR contains a breaking change that MUST NOT be backported check-before-release PR will be looked at again shortly before release and merged if possible. labels Sep 26, 2021
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Sep 26, 2021
felixfontein
felixfontein reviewed Sep 27, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to remove the default for the ignore_volatile_options option, and mention in the documentation that the default is C(true) (because the default isn't printed automatically anymore).

plugins/modules/cloud/lxd/lxd_container.py Outdated Show resolved Hide resolved
changelogs/fragments/3429-enable_deprecaded_message_for_ignore_volatile_option.yml Outdated Show resolved Hide resolved
plugins/modules/cloud/lxd/lxd_container.py Outdated Show resolved Hide resolved
remove default value and modify the resulting checks
f949d58 
spelling fixes
bump version for deprecated messge
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 28, 2021
@felixfontein felixfontein merged commit ef07f9b into ansible-collections:main Sep 28, 2021
@felixfontein
Copy link
Collaborator

@conloos thanks for implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
breaking_change This PR contains a breaking change that MUST NOT be backported cloud feature This issue/PR relates to a feature request module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conloos @felixfontein @ansibullbot