Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for ansible-core 2.11 and 2.12 #7269

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Drop support for ansible-core 2.11 and 2.12 #7269

merged 4 commits into from
Oct 11, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Implement ansible-community/community-topics#271.

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

various

@ansibullbot ansibullbot added WIP Work in progress docs callback callback plugin lookup lookup plugin module_utils module_utils plugins plugin (any type) labels Sep 15, 2023
@felixfontein felixfontein mentioned this pull request Sep 15, 2023
Open
@felixfontein felixfontein added the breaking_change This PR contains a breaking change that MUST NOT be backported label Sep 15, 2023
@felixfontein felixfontein force-pushed the drop-ansible-core-2.11-2.12 branch from b33d329 to a574480 Compare September 19, 2023 16:04
@ansibullbot ansibullbot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Sep 19, 2023
@felixfontein felixfontein force-pushed the drop-ansible-core-2.11-2.12 branch 2 times, most recently from 8bdedc3 to b4814c2 Compare October 4, 2023 21:29
@ansibullbot ansibullbot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Oct 4, 2023
@felixfontein felixfontein requested a review from russoz October 6, 2023 21:30
@felixfontein
Copy link
Collaborator Author

I'm planning to merge this soon after the 8.5.0 release (which will happen probably on Monday).

@felixfontein felixfontein marked this pull request as ready for review October 9, 2023 09:35
@felixfontein felixfontein changed the title [WIP] Drop support for ansible-core 2.11 and 2.12 Drop support for ansible-core 2.11 and 2.12 Oct 9, 2023
@ansibullbot ansibullbot removed the WIP Work in progress label Oct 9, 2023
@felixfontein felixfontein force-pushed the drop-ansible-core-2.11-2.12 branch from b4814c2 to f8f19b8 Compare October 9, 2023 11:32
russoz
russoz reviewed Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit to pick, other than that LGTM

README.md Outdated Show resolved Hide resolved
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Oct 11, 2023
@felixfontein
Copy link
Collaborator Author

CI failure is unrelated and should get fixed by #7385.

felixfontein and others added 4 commits October 11, 2023 09:23
@felixfontein
Drop support for ansible-core 2.11 and 2.12.
db54276 
Also move ansible-core 2.13 from regular CI to EOL CI.
@felixfontein
Remove some compatibility code.
9b2ad64
@felixfontein
Remove no longer needed import.
55720c7
@felixfontein @russoz
Update README.
939a928 
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@felixfontein felixfontein force-pushed the drop-ansible-core-2.11-2.12 branch from ec6807d to 939a928 Compare October 11, 2023 07:23
@felixfontein felixfontein merged commit 4ea40e9 into ansible-collections:main Oct 11, 2023
@felixfontein felixfontein deleted the drop-ansible-core-2.11-2.12 branch October 11, 2023 14:13
@felixfontein
Copy link
Collaborator Author

@russoz thanks a lot for reviewing this!

etrombly pushed a commit to etrombly/community.general that referenced this pull request Oct 25, 2023
@felixfontein @russoz
Drop support for ansible-core 2.11 and 2.12 (ansible-collections#7269)
a18c1e6 
* Drop support for ansible-core 2.11 and 2.12.

Also move ansible-core 2.13 from regular CI to EOL CI.

* Remove some compatibility code.

* Remove no longer needed import.

* Update README.

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

---------

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
JonZeolla added a commit to JonZeolla/policy-as-code that referenced this pull request Nov 1, 2023
@JonZeolla
Set ansible-collections/community.general max version to 7.x
3632185 
See ansible-collections/community.general#7269
@fzadow fzadow mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
breaking_change This PR contains a breaking change that MUST NOT be backported callback callback plugin docs has_issue lookup lookup plugin module_utils module_utils needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @russoz @ansibullbot