Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MH to use the module_utils.vardict.VarDict #8226

Merged
merged 8 commits into from
Apr 23, 2024
Merged

Change MH to use the module_utils.vardict.VarDict #8226

merged 8 commits into from
Apr 23, 2024

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Apr 16, 2024

SUMMARY

The objects in plugins/module_utils/mh/mixins/vars.py are set to be removed in community.general 10.0.0, and the ModuleHelper class still depends on it.

This PR severs that dependency by making use of the more generic code in plugins/module_utils/vardict.py.

While this make look simple, there are many modules depending on ModuleHelper today, so we must be careful with the impact of this change.

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

plugins/module_utils/mh/module_helper.py

@ansibullbot ansibullbot added WIP Work in progress module_utils module_utils plugins plugin (any type) small_patch Hopefully easy to review and removed small_patch Hopefully easy to review labels Apr 16, 2024
@ansibullbot
Copy link
Collaborator

cc @matze
click here for bot help

@ansibullbot ansibullbot added module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Apr 16, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch labels Apr 16, 2024
@ansibullbot
Copy link
Collaborator

cc @Akasurde @jbenden @kevensen @skinp
click here for bot help

@ansibullbot ansibullbot added integration tests/integration tests tests labels Apr 17, 2024
@russoz russoz changed the title WIP: change MH to use the module_utils.vardict.VarDict Change MH to use the module_utils.vardict.VarDict Apr 17, 2024
@ansibullbot ansibullbot removed the WIP Work in progress label Apr 17, 2024
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 23, 2024
@ansibullbot ansibullbot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Apr 23, 2024
@ansibullbot ansibullbot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 23, 2024
@felixfontein felixfontein removed the backport-8 Automatically create a backport for the stable-8 branch label Apr 23, 2024
@felixfontein
Copy link
Collaborator

Thanks :) Feel free to merge this if you don't plan to add more to it.

@russoz russoz merged commit 62138b2 into ansible-collections:main Apr 23, 2024
132 of 133 checks passed
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 23, 2024
@russoz russoz deleted the mh-vardict branch April 24, 2024 21:19
@russoz
Copy link
Collaborator Author

russoz commented Apr 24, 2024

Thanks for the review @felixfontein

@russoz russoz mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
integration tests/integration module_utils module_utils module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein