vmware_host_acceptance: Remove state list #1872
Comments
|
vmware_host_acceptance module must be set of desired acceptance level for host. But show current acceptance level must be another module vmware_host_acceptance_level_info for example. Issues with common module parameter 'state' when we try to combine the functionality of info and desired state modules, imho. |
|
@ihumster Good point. I'll try to create a vmware_host_acceptance_level_info module when I implement this. |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this issue
Oct 15, 2023
vmware_host_acceptance: Remove acceptance_level SUMMARY Fixes #1872 Removing acceptance_level and move its options to state so that acceptance_level: 'community' state: present will become state: 'community' This also means there won't be a state list anymore. In order to get information about the current acceptance level, I will introduce a new module vmware_host_acceptance_info. ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_host_acceptance vmware_host_acceptance_info ADDITIONAL INFORMATION Reviewed-by: Alexander Nikitin <ihumster@ihumster.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SUMMARY
Remove the state
listfromvmware_host_acceptance. The ansible-core sanity tests don't like this.Maybe the best solution would be to remove the
acceptance_levelparameter and use its choices for state.edit:
I will remove
acceptance_leveland move its options tostateso thatwill become
This also means there won't be a state
listanymore. In order to get information about the current acceptance level, I will introduce a new modulevmware_host_acceptance_info.ISSUE TYPE
COMPONENT NAME
vmware_host_acceptance
The text was updated successfully, but these errors were encountered: