@ThatOneCalculator is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

Theme preview (bot)

title_color: #9CCFD8 | icon_color: #C3A6E6 | text_color: #FAF4ED | bg_color: #1f1d29

Link: https://github-readme-stats.vercel.app/api?username=anuraghazra&title_color=9CCFD8&icon_color=C3A6E6&text_color=FAF4ED&bg_color=1f1d29&show_icons=true

Hi thanks for the theme contribution, please read our theme contribution guidelines

We are currently only accepting color combinations from any vscode theme or which has good color combination to minimize bloating the themes collection.

Also note that if this theme is exclusively for your personal use then instead of adding it to our theme collection you can use card customization options

Read our contribution guidelines for more info

Codecov Report

Merging #892 (e8d62ef) into master (a41eb44) will not change coverage.
The diff coverage is n/a.

❗ Current head e8d62ef differs from pull request most recent head 30cf8a4. Consider uploading reports for the commit 30cf8a4 to get more accurate results

@@           Coverage Diff           @@
##           master     #892   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files          22       22           
  Lines         679      679           
  Branches      189      189           
=======================================
  Hits          638      638           
  Misses         37       37           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41eb44...30cf8a4. Read the comment docs.

Theme preview (bot)

title_color: #9CCFD8 | icon_color: #C3A6E6 | text_color: #FAF4ED | bg_color: #1f1d29

Link: https://github-readme-stats.vercel.app/api?username=anuraghazra&title_color=9CCFD8&icon_color=C3A6E6&text_color=FAF4ED&bg_color=1f1d29&show_icons=true

Hi thanks for the theme contribution, please read our theme contribution guidelines

We are currently only accepting color combinations from any vscode theme or which has good color combination to minimize bloating the themes collection.

Also note that if this theme is exclusively for your personal use then instead of adding it to our theme collection you can use card customization options

Read our contribution guidelines for more info

@anuraghazra any update on this? This is a theme that has gained some popularity and does have a dedicated VScode theme :)

@anuraghazra sorry about the late reply -- those 2 things you requested are fixed.

Theme preview (bot)

title_color: #9CCFD8 | icon_color: #C3A6E6 | text_color: #FAF4ED | bg_color: #1f1d29

Link: https://github-readme-stats.vercel.app/api?username=anuraghazra&title_color=9CCFD8&icon_color=C3A6E6&text_color=FAF4ED&bg_color=1f1d29&show_icons=true

Hi thanks for the theme contribution, please read our theme contribution guidelines

We are currently only accepting color combinations from any vscode theme or which has good color combination to minimize bloating the themes collection.

Also note that if this theme is exclusively for your personal use then instead of adding it to our theme collection you can use card customization options

Read our contribution guidelines for more info

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@anuraghazra could you please take a look at this?

@ThatOneCalculator I re-checked your pull request and it looks like the rose_pine_dawn theme does not adhere to the WCAG AAA color contrast standard (see rickstaa#4 (comment)). The rose_pine theme seems to pass (see rickstaa#5 (comment)).

I, therefore, think you might have to remove or improve the rose_pine_dawn theme before it can be merged into the master.

Sorry for the very late reply -- done

@ThatOneCalculator no problem. @anuraghazra, this now looks good to me!

Thanks Rick. I'm on vacation will merge it when I get time.

No hurries enjoy your holiday!

Closed in favour of #1605. I had to rebase since this pull request is quite old.