Fix broken code coverage #164
Labels
help wanted
Extra attention is needed
Comments
|
What about using https://github.com/xd009642/tarpaulin ? |
|
I don't know the difference. Whatever works and produces usable coverage info will do, I suppose. The issue is someone willing to put in the work! |
|
I'm curious about GitHub Actions as well: I've recently switched over some repos from Travis to Actions and so far it seems to be a nice change. In particular, the configuration is a little more straightforward and there's a nice ecosystem of Actions that are easy to use. |
maxcountryman
added a commit
to maxcountryman/sqlparser-rs
that referenced
this issue
Jun 6, 2020
This reworks our GitHub Actions workflow to include code coverage via tarpaulin. Note that this is essentially directly lifted from the again[1] crate's methodology. Fixes apache#164. [1] https://github.com/softprops/again/blob/dd5f0013533e28f803b282ebc281e9525ca64d86/.github/workflows/main.yml
|
I didn't realize there was already a GitHub Actions workflow! 🙂 I put together a quick refactor in case that's a direction you want to go in. |
nickolay
pushed a commit
that referenced
this issue
Jun 7, 2020
This reworks our GitHub Actions workflow to include code coverage via tarpaulin. Fixes #164.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As noted in https://github.com/andygrove/sqlparser-rs/pull/159 ,
cargo coverallsfails in CI with an error due to a change in Cargo.lock format. This is supposed to be fixed in roblabla/cargo-travis#66 , but simply upgrading to that version didn't work for me resulting in linking errors. I did not investigate further.The text was updated successfully, but these errors were encountered: