Skip to content

Support additional DuckDB integer types such as HUGEINT, UHUGEINT, etc #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025

Conversation

alexander-beedie
Copy link
Contributor

@alexander-beedie alexander-beedie commented Apr 4, 2025

  • Adds DataType support for the following integer types, with tests:

    HUGEINT (128bit)
    UHUGEINT (128bit, unsigned)
    UTINYINT
    USMALLINT
    UBIGINT

    (ref: https://duckdb.org/docs/stable/sql/data_types/numeric.html#integer-types)

  • Also: standardised link text/case for database names. Was mixed between (for example) [Postgres], [postgres], [postgresql], etc. That is now standardised to [PostgreSQL], and other DB names were similarly case-standardised (bigquery → BigQuery, clickhouse → ClickHouse, etc).

  • Cleaned up a few other minor nits in the DataType docstrings.


Note: the clippy lint from the new Rust version is addressed by #1796; I can rebase on that once it is merged.

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @alexander-beedie!

@iffyio
Copy link
Contributor

iffyio commented Apr 4, 2025

@alexander-beedie could you merge in latest main in order to fix the ci lint issue?

@alexander-beedie
Copy link
Contributor Author

alexander-beedie commented Apr 5, 2025

@alexander-beedie could you merge in latest main in order to fix the ci lint issue?

@iffyio: done :)

@iffyio iffyio merged commit 4deed26 into apache:main Apr 5, 2025
9 checks passed
@alexander-beedie alexander-beedie deleted the duckdb-integer-types branch April 6, 2025 03:36
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Apr 10, 2025
apache#1797)

Co-authored-by: Alexander Beedie <alexander.beedie@adia.ae>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants