Add support for table valued functions for SQL Server #1839
+230
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- formerly, a semicolon after the last statement in a procedure was non-canonical (because they were added via `join`); a `BeginEndStatements` statements list will always write them out - `BeginEndStatements` begin/end tokens won't be written when empty - EOF now concludes parsing a statement list
…tokens - this further consolidates with existing patterns
2b2a68a to
c04172c
Compare
c04172c to
10e3231
Compare
3686b1b to
db1c9b2
Compare
aharpervc
commented
May 7, 2025
| CREATE FUNCTION some_inline_tvf(@foo INT, @bar VARCHAR(256)) \ | ||
| RETURNS TABLE \ | ||
| AS \ | ||
| RETURN (SELECT 1 AS col_1)\ |
There was a problem hiding this comment.
Parentheses are optional for inline tvf return queries, although I think the subquery expr expects/requires them currently.
There was a problem hiding this comment.
I added support for that syntax & added a new test case example
There was a problem hiding this comment.
UNION is also supported in this syntax but not in this current approach due to using parse_select, which is restricted. I'm comfortable leaving that for later
- rename `AsReturn` to `AsReturnSubquery` for clarity between these two variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: temporarily rebased on #1834, prior to that being merged; I will rebase once it's on main.
This PR adds support for table valued functions for SQL Server, both inline & multi statement functions. For reference, that's the B & C documentation here: https://learn.microsoft.com/en-us/sql/t-sql/statements/create-function-transact-sql?view=sql-server-ver16#b-create-an-inline-table-valued-function
Inline TVF's are defined with
AS RETURN, so we have a newCreateFunctionBody::AsReturnvariant accordingly. Functions using "AS RETURN" don't have BEGIN/END, so that part of the parsing logic is now conditional. Additionally, the data type parser now supports "RETURNS TABLE" without a table definition.Multi statement TVF's use named table expressions, so a new
NamedTabledata type variant was added. I didn't see a great way to integrate this into the existing data type parser (especially without rewinding), so creating this data type happens inside the parse create function logic first by parsing the identifier, then parsing the table definition, then using those elements to produce a NamedTable.I also added a new test example for each of these scenarios.