Redshift: Add support for IAM_ROLE and IGNOREHEADER COPY options #1968
+94
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jul 23, 2025
tests/sqlparser_common.rs
Outdated
| @@ -16256,3 +16256,25 @@ fn parse_notnull() { | |||
| // for unsupported dialects, parsing should stop at `NOT NULL` | |||
| notnull_unsupported_dialects.expr_parses_to("NOT NULL NOTNULL", "NOT NULL"); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn pares_copy_options() { | |||
There was a problem hiding this comment.
Suggested change
| fn pares_copy_options() { | |
| fn parse_copy_options() { |
| #[test] | ||
| fn pares_copy_options() { | ||
| let copy = verified_stmt( | ||
| r#"COPY dst (c1, c2, c3) FROM 's3://redshift-downloads/tickit/category_pipe.txt' IAM_ROLE 'arn:aws:iam::123456789:role/role1' CSV IGNOREHEADER 1"#, |
There was a problem hiding this comment.
Can we add tests to cover the IAM ROLE DEFAULT and CSV IGNOREHEADER AS ... scenarios?
ed0859d to
18c466d
Compare
|
@yoavcloud could you take a look at the conflicts on the branch when you have some time? |
18c466d to
43b9f45
Compare
|
Conflicts resolved @iffyio |
iffyio
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.