Skip to content

Add drop behavior to DROP PRIMARY/FOREIGN KEY #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025

Conversation

yoavcloud
Copy link
Contributor

No description provided.

src/ast/ddl.rs Outdated
"DROP PRIMARY KEY{}",
match drop_behavior {
None => "",
Some(DropBehavior::Restrict) => " RESTRICT",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DropBehavior has Display, so you could use that.

@yoavcloud yoavcloud requested a review from mvzink August 16, 2025 05:37
Copy link
Contributor

@mvzink mvzink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @yoavcloud!
cc @alamb

@iffyio iffyio changed the title Add drop behavior to DROP PRIMARY/FOREIGN KEY Add drop behavior to DROP PRIMARY/FOREIGN KEY Aug 19, 2025
@iffyio iffyio merged commit 12c0878 into apache:main Aug 19, 2025
10 checks passed
@alamb
Copy link
Contributor

alamb commented Aug 19, 2025

Woohoo -- we are past issue/PR 2000 -- a major milestone indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants