Redshift: UNLOAD #2013
Merged
Redshift: UNLOAD #2013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Aug 28, 2025
src/ast/mod.rs
Outdated
| #[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)] | ||
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
| #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))] | ||
| pub struct PartitionBy { |
There was a problem hiding this comment.
Suggested change
| pub struct PartitionBy { | |
| pub struct UnloadPartitionBy { |
Thinking since partitionby has meaning in other contexts?
| /// NULL \[ AS \] 'null_string' | ||
| Null(String), | ||
| /// PARALLEL | ||
| Parallel(Option<bool>), |
There was a problem hiding this comment.
can we add a description here to mention the behavior of on/off?
src/parser/mod.rs
Outdated
| Some(Keyword::GB) => Some(FileSizeUnit::GB), | ||
| _ => None, | ||
| }; | ||
| CopyLegacyOption::RowGroupSize(FileSize { size, unit }) |
There was a problem hiding this comment.
Can we pull this out to a function like parse_file_size_unit() so that it can be reused?
| } else { | ||
| None | ||
| }; | ||
| let with = self.parse_options(Keyword::WITH)?; |
There was a problem hiding this comment.
Can we add a test case that uses the WITH keyword in the syntax?
There was a problem hiding this comment.
There's already one test case at the start of the unit test. This statement has two flavours, one for Athena (using WITH) and one for Redshift (not using WITH).
3b2bb45 to
dcecedf
Compare
iffyio
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the Redshift variant of UNLOAD