Remove PostgreSQL version of assert #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 172299310
💛 - Coveralls |
|
In #226 I assumed both variants (BigQuery and Postgres) of ASSERT were procedural statements. But please feel free to simplify by dropping support for PG's syntax! |
|
Yeah I think that's better, as they are not valid non procedural statements that we should mix with the other ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I linked earlier to this page but didn't notice this was part of PL/pgSQL (so no valid SQL statement in PostgreSQL).
In that case we can better remove the postgres part and simplify the code a bit.
https://www.postgresql.org/docs/10/plpgsql-errors-and-messages.html