Skip to content

Conversation

Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Dec 28, 2020

Also FYI @andygrove I want to add this for DataFusion.

There are quite some different syntax versions for this, so for now I think it is best to stick to ANALYZE TABLE [table_name] and support further syntax later on.

https://www.postgresql.org/docs/9.0/sql-analyze.html
https://spark.apache.org/docs/3.0.0-preview/sql-ref-syntax-aux-analyze-table.html
https://dev.mysql.com/doc/refman/5.6/en/analyze-table.html

@coveralls
Copy link

coveralls commented Dec 28, 2020

Pull Request Test Coverage Report for Build 449165115

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 91.383%

Files with Coverage Reduction New Missed Lines %
src/parser.rs 1 88.86%
Totals Coverage Status
Change from base Build 448700048: 0.02%
Covered Lines: 4857
Relevant Lines: 5315

💛 - Coveralls

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove andygrove merged commit 94ff468 into apache:main Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants