Skip to content

Fix clippy lints #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2021
Merged

Fix clippy lints #287

merged 1 commit into from
Jan 7, 2021

Conversation

joshwd36
Copy link
Contributor

@joshwd36 joshwd36 commented Jan 2, 2021 •
edited
Loading

Implements the changes suggested in clippy. Mostly to do with ranges.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 457851358

  • 32 of 38 (84.21%) changed or added relevant lines in 9 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.7%) to 92.076%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialect/generic.rs 5 8 62.5%
src/dialect/mssql.rs 5 8 62.5%
Files with Coverage Reduction New Missed Lines %
src/dialect/ansi.rs 1 85.71%
src/parser.rs 7 88.39%
Totals Coverage Status
Change from base Build 449512338: 0.7%
Covered Lines: 4857
Relevant Lines: 5275
💛 - Coveralls

Dandandan
Dandandan approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @joshwd36

@Dandandan Dandandan merged commit 17f8eb9 into apache:main Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dandandan Dandandan Dandandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshwd36 @coveralls @Dandandan