Clean up string-related variants in Token and Value #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 111
💛 - Coveralls |
Indeed, given that there is Token::SingleQuotedString and Token::Identifier, there's no other "string" that would make sense...
An identifier is not a literal value, and parse_value is not called on such a token anyway.
...and parser support for the corresponding token, as "..." in SQL[*] is not a literal string like we parse it - but a quoted identifier (which I intend to implement later). [*] in all the RBDMSes I know, except for sqlite which has complex rules in the name of "compatibility": https://www.sqlite.org/lang_keywords.html
Its existence alongside SingleQuotedString simply doesn't make sense: `'a string'` is a string literal, while `a string` is not a "value". It's only used in postgresql-specific tab-separated-values parser to store the string representation of a field's value. For that use-case Option<String> looks like a more appropriate choice than Value.
andygrove
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this moment there are
Value::String,Value::SingleQuotedString, andValue::DoubleQuotedStringand correspondingTokenvariants (plus a separate Token::Identifier).Of these
Tokenof that type, notValue(a866fbc).Token/Value::Stringis mostly unused and doesn't make much sense to me (b8ea37c / 9b5a222)Which leaves
Value::SingleQuotedString,Token::SingleQuotedString, andToken::DoubleQuotedString, for a 50% reduction! :)