Distinguish between INT and INTEGER types
#525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frolovdev
commented
Jun 18, 2022
| @@ -35,7 +35,7 @@ fn parse_create_table_with_defaults() { | |||
| activebool boolean DEFAULT true NOT NULL, | |||
| create_date date DEFAULT now()::text NOT NULL, | |||
| last_update timestamp without time zone DEFAULT now() NOT NULL, | |||
| active integer NOT NULL | |||
| active int NOT NULL | |||
There was a problem hiding this comment.
🎶 I change the test to cover both variants of ints (lean testing)
Pull Request Test Coverage Report for Build 2535650811Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
alamb
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Thank you @frolovdev -- other than the docstring this looks great.
👍
| let optional_precision = self.parse_optional_precision(); | ||
| if self.parse_keyword(Keyword::UNSIGNED) { | ||
| Ok(DataType::UnsignedInt(optional_precision?)) | ||
| } else { | ||
| Ok(DataType::Int(optional_precision?)) | ||
| } | ||
| } | ||
| Keyword::INTEGER => { |
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Applied |
|
Thanks again @frolovdev ! |
mobuchowski
pushed a commit
to mobuchowski/sqlparser-rs
that referenced
this pull request
Aug 3, 2022
* support integer * fmt * Update src/ast/data_type.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This was referenced Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alamb (you said that I can ping you :d)
Closes #398