Skip to content

[ISSUE #4994] unit tests for HttpRequestUtil.java #5037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

Abhichede
Copy link
Contributor

Fixes #4994

Motivation

Increase test coverage

Modifications

Added new tests for HttpRequestUtil.java located at [eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util]

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives

@harshithasudhakar
Copy link
Member

Hi, thanks for contributing. Please fix the checkstyle violations.

@Abhichede
Copy link
Contributor Author

@harshithasudhakar i have fixed the checks. could you approve the actions?

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@Pil0tXia Pil0tXia merged commit ec55804 into apache:master Jul 17, 2024
10 checks passed
@Abhichede Abhichede deleted the test/4994 branch July 17, 2024 04:18
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
* test: adds unit tests for HttpRequestUtil.java

* fix: fixes checkstyle warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Unit Test] Unit test for HttpRequestUtil.java
3 participants