Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Remove urllib.quote calls - already handled by urllib.encode in AsyncRequest #2

Merged
merged 1 commit into from
Sep 19, 2013
Merged

Remove urllib.quote calls - already handled by urllib.encode in AsyncRequest #2

merged 1 commit into from
Sep 19, 2013

Conversation

victorhooi
Copy link
Contributor

@k4hoo
Copy link
Contributor

k4hoo commented Sep 19, 2013

I think we only need to remove the url.quote() for the uid/iid which is passed to AsyncRequest() as query params.
Since the query param is URL-encoded inside the connection.py as you found.
For the uid/iid used in path var (eg path = "%s/users/%s.json" % (self.apiversion, enc_uid)), we still want to keep the url.quote() it because it's used as URL path directly.

k4hoo added a commit that referenced this pull request Sep 19, 2013
@k4hoo
Merge pull request #2 from victorhooi/develop
cabb6fc 
Remove urllib.quote calls - already handled by urllib.encode in AsyncRequest
@k4hoo k4hoo merged commit cabb6fc into apache:develop Sep 19, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorhooi @k4hoo