[improve][broker] Decouple pulsar_storage_backlog_age_seconds metric with backlogQuota check #23619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from backlogQuota policy
8b8ffc8 to
e2a102f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23619 +/- ##
============================================
+ Coverage 73.57% 74.35% +0.78%
- Complexity 32624 34488 +1864
============================================
Files 1877 1944 +67
Lines 139502 147239 +7737
Branches 15299 16248 +949
============================================
+ Hits 102638 109486 +6848
- Misses 28908 29309 +401
- Partials 7956 8444 +488
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
reviewed
Nov 27, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
poorbarcode
approved these changes
Nov 28, 2024
zymap
reviewed
Dec 6, 2024
| // If backlog quota by time is not set | ||
| if (backlogQuotaLimitInSecond <= 0) { | ||
| return CompletableFuture.completedFuture(false); | ||
| if (!(ledger.getCursors() instanceof ManagedCursorContainer managedCursorContainer)) { |
There was a problem hiding this comment.
Since the ledger.getCursors() exposes the API by an interface, shouldn’t let the implementation to decide the result?
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 6, 2024
…with backlogQuota check (apache#23619) (cherry picked from commit 963be2c) (cherry picked from commit 12eccd2)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 9, 2024
…with backlogQuota check (apache#23619) (cherry picked from commit 963be2c) (cherry picked from commit 12eccd2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#21709 introduced a valuable metric: pulsar_storage_backlog_age_seconds, but it only updates when a topic has the message_age backlog quota policy.
Modifications
backlogQuotaCheckeris also used to periodically update thepulsar_storage_backlog_age_secondsmetric, regardless of whether the topic has a backlog quota policy.Verifying this change
backlogsAgeMetricsNoPreciseWithoutBacklogQuotaandbacklogsAgeMetricsPreciseWithoutBacklogQuotato cover this change.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: