Skip to content

Add COC file, remove some files from generated archives #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2018

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented May 29, 2018

@dunglas dunglas requested a review from teohhanhui May 29, 2018 16:58
@teohhanhui
Copy link
Contributor

teohhanhui commented May 30, 2018

Why are they under .github directory? Is there special handling of those files by GitHub? But anyway, I don't think that's a good idea.

@soyuka
Copy link
Member

soyuka commented May 30, 2018

Why are they under .github directory? Is there special handling of those files by GitHub? But anyway, I don't think that's a good idea.

Yes they're then linking these files when you open an issue for example. Anyway according to the docs, these files can also be at the root of the project. I'd be 👍 to leave them there (ie not in .github) for visibility.

Add the CODE_OF_CONDUCT.md file to the root, docs/, or .github/ folder.

https://help.github.com/articles/adding-a-code-of-conduct-to-your-project/

@dunglas dunglas merged commit 896f295 into api-platform:master Jun 7, 2018
@dunglas dunglas deleted the exlucde-and-coc branch June 7, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants