Skip to content

feat: Add unqiue_key based methods to RequestQueueClient #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

feat: Add unqiue_key based methods to RequestQueueClient #480

wants to merge 5 commits into from

Conversation

Pijukatel
Copy link
Contributor

Description

  • Add unqiue_key based methods to RequestQueueClient as an alternative to id based methods
  • Add function to transform unqiue_key to id

Issues

@github-actions github-actions bot added this to the 121st sprint - Tooling team milestone Aug 20, 2025
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Aug 20, 2025
@Pijukatel Pijukatel mentioned this pull request Aug 20, 2025
Draft
@Pijukatel Pijukatel requested review from vdusek and janbuchar August 20, 2025 08:05
@Pijukatel Pijukatel marked this pull request as ready for review August 20, 2025 08:05
@Pijukatel
Update request_queue.py
9b7853b 
Update docstrings
vdusek
vdusek requested changes Aug 20, 2025
View reviewed changes
@Pijukatel Pijukatel requested a review from vdusek August 20, 2025 09:57
vdusek
vdusek approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Honza just raised some concerns about whether this should be here or in the SDK, so let's wait for his confirmation as well (both options work for me).

@Pijukatel
Copy link
Contributor Author

Will be handled in sdk instead

@Pijukatel Pijukatel closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

@janbuchar janbuchar Awaiting requested review from janbuchar

Assignees

@Pijukatel Pijukatel

Labels
t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
121st sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@Pijukatel @vdusek