Skip to content

fix: Try to solve race conditions #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 12, 2025
Merged

fix: Try to solve race conditions #544

merged 13 commits into from
Aug 12, 2025

Conversation

Pijukatel
Copy link
Contributor

@Pijukatel Pijukatel commented Aug 12, 2025 •
edited
Loading

@Pijukatel Pijukatel changed the title Try to solve race conditions fix: Try to solve race conditions Aug 12, 2025
@Pijukatel Pijukatel added the t-tooling Issues with this label are in the ownership of the tooling team. label Aug 12, 2025
@Pijukatel Pijukatel marked this pull request as ready for review August 12, 2025 12:57
@Pijukatel Pijukatel force-pushed the new-storages-race-conditions branch from f653255 to 5395029 Compare August 12, 2025 14:48
vdusek
vdusek reviewed Aug 12, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please add comments to all the usage of the new lock? Why are they there, what do they solve...

vdusek
vdusek approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

@Pijukatel Pijukatel merged commit 9d5e86e into new-apify-storage-clients Aug 12, 2025
18 of 21 checks passed
@Pijukatel Pijukatel deleted the new-storages-race-conditions branch August 12, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

Assignees
No one assigned
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pijukatel @vdusek