fix: Fix memory estimation not working on MacOS #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
approved these changes
Jul 29, 2025
|
Manually tested on MacOs. Thanks @vladfrangu Two issues on MacOS in the original code before the PR:
|
Mantisus
pushed a commit
to Mantisus/crawlee-python
that referenced
this pull request
Jul 30, 2025
### Description - Use `pss` for memory estimation only on Linux. - Use `rss` for memory estimation only on MacOs. ### Issues - Closes: apify#1329
Pijukatel
added a commit
that referenced
this pull request
Jul 30, 2025
### Description - Use `pss` for memory estimation only on Linux. - Use `rss` for memory estimation only on MacOs. ### Issues - Closes: #1329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pssfor memory estimation only on Linux.rssfor memory estimation only on MacOs.Issues