Skip to content

Update Selenium version to v4.34.0 +semver: feature #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

Update Selenium version to v4.34.0 +semver: feature #271

merged 1 commit into from
Jul 18, 2025

Conversation

mialeska
Copy link
Contributor

update extensions to use latest available devTools v137
stabilize ManyTools tests by removing cookie consent

@mialeska
Update Selenium version to v4.34.0 +semver: feature
f782009 
update extensions to use latest available devTools v137
stabilize ManyTools tests by removing cookie consent
@mialeska mialeska self-assigned this Jul 18, 2025
@mialeska mialeska added enhancement New feature or request dotnet labels Jul 18, 2025
@github-project-automation github-project-automation bot moved this to In progress in Aquality Selenium Jul 18, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 18, 2025 •
edited
Loading

Walkthrough

This update increments package versions for Aquality.Selenium.Core, WebDriverManager, and Microsoft.NET.Test.Sdk. It also updates DevTools protocol references from V137 to V138 in both code and XML documentation. Additionally, some obsolete code related to page load and consent button handling is removed from a test form.

Changes

File(s) Change Summary
.../Aquality.Selenium.csproj, .../Aquality.Selenium.Tests.csproj Updated package versions (Aquality.Selenium.Core, WebDriverManager, Microsoft.NET.Test.Sdk).
.../Browsers/DevToolsEmulationExtensions.cs, .../Browsers/DevToolsPerformanceExtensions.cs Changed DevTools protocol imports from V137 to V138.
.../Aquality.Selenium.xml Updated XML documentation to reference DevTools V138 instead of V137.
.../ManyToolsForm.cs Removed obsolete consent button logic and page load wait from the Open() method.

Sequence Diagram(s)

sequenceDiagram
    participant Test as TestApp
    participant ManyToolsForm
    participant Browser

    Test->>ManyToolsForm: Open()
    ManyToolsForm->>Browser: GoTo(URL)
    Note over ManyToolsForm: Retry logic for navigation remains\nConsent button handling removed
Loading

Possibly related PRs

  • #264: Introduces Aquality.Selenium.Images package and restructures ByImage locator, related through DevTools and dependency management.
  • #253: Also updates Aquality.Selenium.Core and WebDriverManager versions, related by package version changes.
  • #270: Updates DevTools protocol from V135 to V137, similar to this PR's update from V137 to V138.

Suggested labels

feature

Poem

In the code fields where selenium bunnies play,
We hop from V137 to V138 today.
Old consent buttons now gone from our sight,
With fresher dependencies, everything feels right.
🐇✨
The tests will run smooth,
As we leap to improve!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b8fd334 and f782009.

📒 Files selected for processing (6)
  • Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.csproj (1 hunks)
  • Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.xml (4 hunks)
  • Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs (1 hunks)
  • Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsPerformanceExtensions.cs (1 hunks)
  • Aquality.Selenium/tests/Aquality.Selenium.Tests/Aquality.Selenium.Tests.csproj (1 hunks)
  • Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/TestApp/ManyTools/Forms/ManyToolsForm.cs (1 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings 
Learnt from: mialeska
PR: aquality-automation/aquality-selenium-dotnet#270
File: Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs:3-4
Timestamp: 2025-05-28T19:52:19.309Z
Learning: DevTools V137 namespaces (OpenQA.Selenium.DevTools.V137.DOM and OpenQA.Selenium.DevTools.V137.Emulation) are available and working in Selenium WebDriver 4.33.0 for .NET projects.

Learnt from: mialeska
PR: aquality-automation/aquality-selenium-dotnet#264
File: Aquality.Selenium/src/Aquality.Selenium.Images/Aquality.Selenium.Images.csproj:41-48
Timestamp: 2024-10-09T11:11:38.254Z
Learning: In `Aquality.Selenium.Images.csproj`, different versions of `OpenCvSharp4` package references are acceptable because the packages are compatible.
Aquality.Selenium/tests/Aquality.Selenium.Tests/Aquality.Selenium.Tests.csproj (2) 
Learnt from: mialeska
PR: aquality-automation/aquality-selenium-dotnet#264
File: Aquality.Selenium/src/Aquality.Selenium.Images/Aquality.Selenium.Images.csproj:41-48
Timestamp: 2024-10-09T11:11:38.254Z
Learning: In `Aquality.Selenium.Images.csproj`, different versions of `OpenCvSharp4` package references are acceptable because the packages are compatible.

Learnt from: mialeska
PR: aquality-automation/aquality-selenium-dotnet#270
File: Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs:3-4
Timestamp: 2025-05-28T19:52:19.309Z
Learning: DevTools V137 namespaces (OpenQA.Selenium.DevTools.V137.DOM and OpenQA.Selenium.DevTools.V137.Emulation) are available and working in Selenium WebDriver 4.33.0 for .NET projects.
Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsPerformanceExtensions.cs (2) 
Learnt from: mialeska
PR: aquality-automation/aquality-selenium-dotnet#270
File: Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs:3-4
Timestamp: 2025-05-28T19:52:19.309Z
Learning: DevTools V137 namespaces (OpenQA.Selenium.DevTools.V137.DOM and OpenQA.Selenium.DevTools.V137.Emulation) are available and working in Selenium WebDriver 4.33.0 for .NET projects.

Learnt from: mialeska
PR: aquality-automation/aquality-selenium-dotnet#264
File: Aquality.Selenium/src/Aquality.Selenium.Images/Aquality.Selenium.Images.csproj:41-48
Timestamp: 2024-10-09T11:11:38.254Z
Learning: In `Aquality.Selenium.Images.csproj`, different versions of `OpenCvSharp4` package references are acceptable because the packages are compatible.
Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.csproj (2) 
Learnt from: mialeska
PR: aquality-automation/aquality-selenium-dotnet#264
File: Aquality.Selenium/src/Aquality.Selenium.Images/Aquality.Selenium.Images.csproj:41-48
Timestamp: 2024-10-09T11:11:38.254Z
Learning: In `Aquality.Selenium.Images.csproj`, different versions of `OpenCvSharp4` package references are acceptable because the packages are compatible.

Learnt from: mialeska
PR: aquality-automation/aquality-selenium-dotnet#270
File: Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs:3-4
Timestamp: 2025-05-28T19:52:19.309Z
Learning: DevTools V137 namespaces (OpenQA.Selenium.DevTools.V137.DOM and OpenQA.Selenium.DevTools.V137.Emulation) are available and working in Selenium WebDriver 4.33.0 for .NET projects.
Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs (2) 
Learnt from: mialeska
PR: aquality-automation/aquality-selenium-dotnet#270
File: Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs:3-4
Timestamp: 2025-05-28T19:52:19.309Z
Learning: DevTools V137 namespaces (OpenQA.Selenium.DevTools.V137.DOM and OpenQA.Selenium.DevTools.V137.Emulation) are available and working in Selenium WebDriver 4.33.0 for .NET projects.

Learnt from: mialeska
PR: aquality-automation/aquality-selenium-dotnet#264
File: Aquality.Selenium/src/Aquality.Selenium.Images/Aquality.Selenium.Images.csproj:41-48
Timestamp: 2024-10-09T11:11:38.254Z
Learning: In `Aquality.Selenium.Images.csproj`, different versions of `OpenCvSharp4` package references are acceptable because the packages are compatible.
Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.xml (2) 
Learnt from: mialeska
PR: aquality-automation/aquality-selenium-dotnet#270
File: Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs:3-4
Timestamp: 2025-05-28T19:52:19.309Z
Learning: DevTools V137 namespaces (OpenQA.Selenium.DevTools.V137.DOM and OpenQA.Selenium.DevTools.V137.Emulation) are available and working in Selenium WebDriver 4.33.0 for .NET projects.

Learnt from: mialeska
PR: aquality-automation/aquality-selenium-dotnet#264
File: Aquality.Selenium/src/Aquality.Selenium.Images/Aquality.Selenium.Images.csproj:41-48
Timestamp: 2024-10-09T11:11:38.254Z
Learning: In `Aquality.Selenium.Images.csproj`, different versions of `OpenCvSharp4` package references are acceptable because the packages are compatible.
🔇 Additional comments (6)
Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsPerformanceExtensions.cs (1)

1-1: DevTools protocol version update looks good.

The namespace update from V137 to V138 for Performance aligns with the PR's objective to use the latest DevTools version 138. No functional changes were made.

Aquality.Selenium/tests/Aquality.Selenium.Tests/Aquality.Selenium.Tests.csproj (1)

37-37: Test SDK version update is appropriate.

The minor version update from 17.14.0 to 17.14.1 for Microsoft.NET.Test.Sdk keeps the testing environment current with the latest patches.

Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs (1)

3-4: DevTools protocol version update is consistent.

The namespace updates from V137 to V138 for both DOM and Emulation maintain consistency and align with the PR's objective to use the latest DevTools version 138.

Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.csproj (1)

94-95: Package version updates are appropriate.

The version increments are logical: Aquality.Selenium.Core (3.3.0 → 3.4.0) for minor features and WebDriverManager (2.17.5 → 2.17.6) for patches. These updates support the DevTools protocol version changes.

Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/TestApp/ManyTools/Forms/ManyToolsForm.cs (1)

18-18: Cookie consent removal improves test stability.

The removal of the AgreeButton property and associated cookie consent handling logic aligns with the PR objective to stabilize ManyTools tests by addressing cookie consent interruptions.

Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.xml (1)

480-482: Namespace version updated correctly

The example now references OpenQA.Selenium.DevTools.V138, which is consistent with the production code change and Selenium 4.34.0.
No further action required.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-to-selenium-4.34.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mialeska mialeska merged commit 84e2ae6 into master Jul 18, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Aquality Selenium Jul 18, 2025
@mialeska mialeska deleted the update-to-selenium-4.34.0 branch July 18, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@mialeska mialeska

Labels
dotnet enhancement New feature or request
Projects
Aquality Selenium
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mialeska