Skip to content

Feature/access token #21650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 11, 2025
Merged

Feature/access token #21650

merged 17 commits into from
Mar 11, 2025

Conversation

fceller
Copy link
Contributor

@fceller fceller commented Feb 28, 2025 •
edited by Simran-B
Loading

Scope & Purpose

This PR implements https://github.com/arangodb/documents/blob/master/DesignDocuments/04_IMPLEMENTED/AccessToken.md

  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 📖 CHANGELOG entry made
  • 📚 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: (Please link PR)
    • Backport for 3.11: (Please link PR)
    • Backport for 3.10: (Please link PR)

Related Information

There will be a documentation PR.

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

@cla-bot cla-bot bot added the cla-signed label Feb 28, 2025
@fceller fceller self-assigned this Feb 28, 2025
@fceller fceller requested review from a team and neunhoef February 28, 2025 11:12
@fceller
Copy link
Contributor Author

fceller commented Feb 28, 2025

Tests are still missing.

johann-listunov
johann-listunov reviewed Feb 28, 2025
View reviewed changes
@fceller fceller marked this pull request as ready for review March 6, 2025 10:03
@fceller
Copy link
Contributor Author

fceller commented Mar 6, 2025

@neunhoef @johann-listunov @dothebart tests added.

@Simran-B documentation is in the design document

dothebart
dothebart approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@dothebart dothebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if possible we should move away from the requests module.
Otherwise LGTM.

@fceller
Copy link
Contributor Author

fceller commented Mar 6, 2025

I think if possible we should move away from the requests module. Otherwise LGTM.

@dothebart I assume this is a separate, general project?

@dothebart
Copy link
Contributor

here you have an example how to work with the arango.POST_RAW module: https://github.com/arangodb/arangodb/blob/devel/tests/js/client/shell/api/aqlfunction.js

@KVS85 KVS85 added this to the devel milestone Mar 10, 2025
@fceller
Copy link
Contributor Author

fceller commented Mar 10, 2025

@neunhoef @johann-listunov are you happy with the PR? I want to merge

@fceller fceller merged commit cdbd3d5 into devel Mar 11, 2025
7 checks passed
@fceller fceller deleted the feature/access-token branch March 11, 2025 08:29
@Simran-B Simran-B mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dothebart dothebart dothebart approved these changes

@neunhoef neunhoef Awaiting requested review from neunhoef

@johann-listunov johann-listunov Awaiting requested review from johann-listunov

Assignees

@fceller fceller

Labels
cla-signed
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
4 participants
@fceller @dothebart @johann-listunov @KVS85