Fix vector index missing in telemetrics #21788
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbajic
commented
Jun 2, 2025
| "edge", "geo", "hash", "fulltext", "inverted", | ||
| "persistent", "skiplist", "ttl", "mdi", "mdi-prefixed", | ||
| "iresearch", "primary", "unknown"}; | ||
| "iresearch", "primary", "vector", "unknown"}; |
There was a problem hiding this comment.
For telemetry schema consistency, we need to always report the vector index here, regardless of whether it is used or not.
jvolmer
approved these changes
Jun 2, 2025
| return { | ||
| setUpAll: function () { | ||
| db._create(cn); | ||
| let coll = db._createEdgeCollection(cn3, {numberOfShards: 2}); |
There was a problem hiding this comment.
Is there a reason why the edge collection has 2 shards and the document collection has one?
There was a problem hiding this comment.
Nope I forgot about it. I will remove the uneeded stuff from the setup
|
|
||
| function validateObjectAgainstSchema(obj, fieldDefinitions, currentPath) { | ||
| let allErrors = []; | ||
| const dataKeys = new Set(Object.keys(obj)); |
There was a problem hiding this comment.
I don't see why we need this variable
There was a problem hiding this comment.
allErrors reports all found violations agains schema and dataKeys severs to check if some fields are duplicates
| if (mode !== "NULLABLE" && mode !== "REPEATED") { | ||
| // This case is for fields that are implicitly "REQUIRED". | ||
| // Given the schema's explicit modes, this path usually means the field is optional. | ||
| // errors.push(`Error at "${path}": Field is required but missing.`); |
There was a problem hiding this comment.
why is this commented out? if it stays like this, we don't need this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Vector index
n_vectorwas missing in telemetrics is now added.Checklist
Related Information
(Please reference tickets / specification / other PRs etc)