Fix unique key generation [BTS-2209] #21913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neunhoef
commented
Aug 25, 2025
| @@ -1138,31 +1138,17 @@ function KeyGenerationLocationSuite() { | |||
| db._drop(cn); | |||
| }, | |||
|
|
|||
| testThatFailurePointsWork1: function () { | |||
There was a problem hiding this comment.
This test has never worked, since if the failure point did not work, it was green. Now, it cannot be kept, since there should be no situation any more which triggers the single server key generator on a dbserver in a cluster.
neunhoef
commented
Aug 25, 2025
| try { | ||
| c.insert({}); | ||
| fail(); |
There was a problem hiding this comment.
This is necessary to make the test fail, if the failure point does not work.
mchacki
requested changes
Aug 26, 2025
|
should there as well be test covearge from this in the dump/restore tests in:
|
|
No, I do not think we need test coverage in dump/restore for this. In the end, restore operations will usually include keys, so key generation will not be triggered at all, as far as I can see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses https://arangodb.atlassian.net/browse/BTS-2209
The problem arises if there is an AQL INSERT statement in a loop
for a collection which has either exactly one shard or it has
multiple shards and the option
forceOneShardAttributeValueisused for the case that no user-specified
_keyis given.Design doc: https://github.com/arangodb/documents/blob/master/DesignDocuments/03_IN_PROGRESS/DuplicateIdsFix.md
Scope & Purpose
Checklist