Skip to content

[BTS-2217] Attempting to STOP a non-started feature #21940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2025
Merged

[BTS-2217] Attempting to STOP a non-started feature #21940

merged 3 commits into from
Sep 4, 2025
+12 −0

Conversation

markuspf
Copy link
Contributor

@markuspf markuspf commented Sep 2, 2025 •
edited
Loading

If an error happens during ApplicationServer::start(), the function attempts to shutdown all previously started features.

During startup only the enabled features are started, non-enabled features are skipped.

The shutdown loop was missing the code skipping non-enabled features and hence ran into an `ADB_PROD_ASSERT.

Testing the above fix I also found that the server is not put into the correct state when stopping and unpreparing features, so that code is added, too.

Scope & Purpose

(Please describe the changes in this PR for reviewers, motivation, rationale - mandatory)

  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 📖 CHANGELOG entry made
  • 📚 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: (Please link PR)
    • Backport for 3.11: (Please link PR)
    • Backport for 3.10: (Please link PR)

Related Information

(Please reference tickets / specification / other PRs etc)

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

@cla-bot cla-bot
Copy link

cla-bot bot commented Sep 2, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Markus Pfeiffer.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@markuspf markuspf force-pushed the bug-fix/bts-2217-skip-non-enabled-features-on-shutdown branch from 3bee31c to 8775f53 Compare September 2, 2025 14:28
@cla-bot cla-bot
Copy link

cla-bot bot commented Sep 2, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Markus Pfeiffer.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@markuspf markuspf force-pushed the bug-fix/bts-2217-skip-non-enabled-features-on-shutdown branch from 8775f53 to d7d07b3 Compare September 2, 2025 14:30
@cla-bot cla-bot
Copy link

cla-bot bot commented Sep 2, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Markus Pfeiffer.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@markuspf markuspf force-pushed the bug-fix/bts-2217-skip-non-enabled-features-on-shutdown branch from d7d07b3 to fd48100 Compare September 2, 2025 14:32
@cla-bot cla-bot bot added the cla-signed label Sep 2, 2025
@markuspf markuspf changed the title Fix BTS-2217 (Attempting to STOP a non-started feature) [BTS-2217] Attempting to STOP a non-started feature Sep 2, 2025
@markuspf markuspf self-assigned this Sep 2, 2025
@markuspf markuspf added this to the 3.12.6 milestone Sep 2, 2025
@markuspf
Copy link
Contributor Author

markuspf commented Sep 3, 2025

As a point of reference, the feature that caused this kerfuffle is the DocumentStateMachine which is part of Replication2, which means that the code is still around, intentional or not.

The bug fixed is a genuine bug in the startup/shutdown code, though, so this fix should go in regardless.

jvolmer
jvolmer approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@jvolmer jvolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markuspf
Fix BTS-2217
0fef0c6 
If an error happens during ApplicationServer::start(), the function
attempts to shutdown all previously started features.

During startup only the enabled features are started, non-enabled
features are skipped.

The shutdown loop was missing the code skipping non-enabled features
and hence ran into an ADB_PROD_ASSERT.
@markuspf
Add CHANGELOG entry
5fcc509
@markuspf
Properly signal that the server is shutting down
7775b20
@markuspf markuspf force-pushed the bug-fix/bts-2217-skip-non-enabled-features-on-shutdown branch from 17e2404 to 7775b20 Compare September 4, 2025 13:24
jvolmer
jvolmer approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@jvolmer jvolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks still good to me :)

@neunhoef neunhoef merged commit 7e1a6b8 into devel Sep 4, 2025
5 checks passed
@neunhoef neunhoef deleted the bug-fix/bts-2217-skip-non-enabled-features-on-shutdown branch September 4, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvolmer jvolmer jvolmer approved these changes

Assignees

@markuspf markuspf

Labels
cla-signed
Projects
None yet
Milestone
3.12.6
Development

Successfully merging this pull request may close these issues.
3 participants
@markuspf @jvolmer @neunhoef